Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: centralize hermetic build workflow implementations #2765

Closed
wants to merge 4 commits into from

Conversation

diegomarquezp
Copy link
Contributor

This PR transfers the workflows and their implementations involved in hermetic library generation (i.e. update_googleapis_committish.yaml and hermetic_library_generation.yaml).

The purpose is to simplify the hermetic build setup requirements in HW libraries and google-cloud-java to simply declare two workflows that will delegate all the logic to the workflows and their corresponding scripts stored in sdk-platform-java.

Follow ups:

  • In google-cloud-java, remove generation/update_googleapis_commit.sh and hermetic_library_generation.sh, plus the workflows that use them.

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label May 12, 2024
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@diegomarquezp
Copy link
Contributor Author

We will use synthtool templates for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant