-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(merge-on-green)!: remove restrictions for checking reviews for merge on green #5231
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main change seems ok, but a nit about the test
@@ -422,7 +422,7 @@ describe('merge-on-green wrapper logic', () => { | |||
|
|||
const [reducedPRs] = handler.maybeReducePRList(prs); | |||
|
|||
assert.strictEqual(reducedPRs.length, 25); | |||
assert.ok(reducedPRs.length === 24 || reducedPRs.length === 25); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be confident in this value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's OK if we're not confident. It's produced by a random value, and the only requirement is that it has to be under 25 (the chunk size):
const index = Math.round(Math.random() * prs.length); |
Friendly ping @chingor13 |
|
LICENSE |
When we initially created merge-on-green, we weren't sure whether repos had set up branch protection adequately, so we wrote additional logic to make sure PRs had reviews. However, we've since instituted org-wide protection, this seems like an additional piece of logic now that causes a lot of confusion, see: #5193