Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add group name to branch name #1924

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

bahrmichael
Copy link

@bahrmichael bahrmichael commented Apr 18, 2023

Heya 👋

I'm intentionally opening this PR before being done with all the tests/docs because I'd like your feedback on this approach.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea: Head branch does not contain group name #1923
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed) TBD
  • Appropriate docs were updated (if necessary) TBD

Fixes #1923 🦕

@bahrmichael bahrmichael requested review from a team as code owners April 18, 2023 15:21
@google-cla
Copy link

google-cla bot commented Apr 18, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Apr 18, 2023
@bahrmichael bahrmichael changed the title Fix/missing group head branch fix: add group name to branch name Apr 18, 2023
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I change this file to add and run the Merge plugin afterwards, because that way the if condition was much simpler to read.

I'm expanding the if condition to also check for the number of new pull requests, so that it won't attempt a merge if there aren't multiple PRs that should be merged together. While updating the code for the linked-versions project we encountered a problem where one remaining PR was renamed because of the merge attempt of 1 PR.

@bahrmichael
Copy link
Author

@chingor13 Could you take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Head branch does not contain group name
3 participants