Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding local testing documentation to contributing guide. #1740

Closed
wants to merge 3 commits into from
Closed

chore: Adding local testing documentation to contributing guide. #1740

wants to merge 3 commits into from

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Nov 3, 2022

Hi team, just adding some stuff to the guide that maybe useful for contributors.

@ddixit14 ddixit14 requested a review from a team as a code owner November 3, 2022 19:29
@ddixit14 ddixit14 requested a review from a team November 3, 2022 19:29
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 3, 2022
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM, with the minor change to add \ for the multi-line bash command

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
ddixit14 and others added 2 commits November 7, 2022 15:31
Co-authored-by: Jeff Ching <chingor@google.com>
Co-authored-by: Jeff Ching <chingor@google.com>
@ddixit14 ddixit14 closed this by deleting the head repository Nov 7, 2022
@ddixit14 ddixit14 reopened this Nov 8, 2022
@ddixit14
Copy link
Contributor Author

ddixit14 commented Nov 8, 2022

Apologies, this got closed on its own because I deleted the fork. Reopening it for @chingor13's approval.

@suztomo
Copy link
Member

suztomo commented Nov 8, 2022

Can you check the formatted view? I don't think you fixed the problem.

image

## Testing a new feature using CLI

1. After you've written some new code, in order to test it out, you can use the [CLI][CLI].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the step to generate release-please command?

@ddixit14
Copy link
Contributor Author

ddixit14 commented Nov 8, 2022

Closing this in favor of #1743.

@ddixit14 ddixit14 closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants