fix(go-yoshi): dynamically load list of ignored submodules for google-cloud-go #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @codyoss |
bcoe
approved these changes
Feb 14, 2022
chingor13
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 16, 2022
🤖 I have created a release *beep* *boop* --- ### [13.4.10](v13.4.9...v13.4.10) (2022-02-16) ### Bug Fixes * **go-yoshi:** dynamically load list of ignored submodules for google-cloud-go ([#1291](#1291)) ([36f6ad9](36f6ad9)) * manifest release can handle componentless entry ([#1300](#1300)) ([6b58573](6b58573)) * return uploadUrl and body when creating release ([#1298](#1298)) ([5d767c5](5d767c5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root module was always intended to only include non-submodule components. We now dynamically load the list by finding the
go.modfiles in the repository.This fixes the root component release PRs to look like: googleapis/google-cloud-go#5498