Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding local testing steps to contributing guide #1743

Merged
merged 3 commits into from Nov 10, 2022

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Nov 8, 2022

Hi team, just adding some stuff to the guide that maybe useful for contributors.

@suztomo Opened this new PR because I was unable to edit the last one, looks like I messed up with the head of that branch while working on the versioning strategy. Also, there are no steps to generate release-please command afaik. It is included in the node build command. Multi-line command is fixed.

image

@chingor13 can you please approve this one?

@ddixit14 ddixit14 requested a review from a team as a code owner November 8, 2022 14:19
@ddixit14 ddixit14 requested a review from a team November 8, 2022 14:19
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 8, 2022
@suztomo
Copy link
Member

suztomo commented Nov 8, 2022

node build command

Write down that.

In another project (owlbot bootstrapper) it is "npm compile && npm link"

@ddixit14
Copy link
Contributor Author

ddixit14 commented Nov 8, 2022

node build command

Write down that.

I have already done that.

A074C7D9-0B36-4092-ABBE-4C12B339C506

@suztomo
Copy link
Member

suztomo commented Nov 8, 2022

@ddixit14 That 2nd part, "node build/src .." command, seems correct. But the 1st part, "release-please release-pr .." command, does not use the some new code without the command is rebuilt.

@ddixit14
Copy link
Contributor Author

ddixit14 commented Nov 8, 2022

@ddixit14 That 2nd part, "node build/src .." command, seems correct. But the 1st part, "release-please release-pr .." command, does not use the some new code without the command is rebuilt.

I don't understand what you're trying to say.
The first command ""release-please release-pr .." is your normal CLI command. This is just an example of a release-please CLI command (this is not related to building from source or anything).
You can run the equivalent of this CLI command from your source (after doing some code changes) using the 2nd command.


```
release-please release-pr \
node build/src/bin/release-please.js release-pr \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's clear. Thank you.

@suztomo
Copy link
Member

suztomo commented Nov 10, 2022

@bcoe Can you merge this?


```
node build/src/bin/release-please.js release-pr \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build/src/bin/release-please.js? Not typescript?

@chingor13 chingor13 merged commit 09ae5a2 into googleapis:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants