Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dependencies)!: Upgrade to google-cloud-datastore 2.x #841

Merged
merged 7 commits into from
Dec 6, 2022
Merged

feat(dependencies)!: Upgrade to google-cloud-datastore 2.x #841

merged 7 commits into from
Dec 6, 2022

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Nov 21, 2022 •
edited

Fixes #804

BEGIN_COMMIT_OVERRIDE
feat(dependencies)!: Upgrade to google-cloud-datastore >= 2.7.2
fix: Update module imports
fix: Fix enum namespaces
fix: Update datastore stub creation
fix: Update API capitalization/casing
fix: Correct access to SerializeToString, CopyFrom, and MergeFromString
test: Fix tests
END_COMMIT_OVERRIDE

See the python-datastore upgrade guide for information on how to upgrade your own code that uses google-cloud-datastore 1.x

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Nov 21, 2022
@rwhogg rwhogg force-pushed the bump-deps branch 3 times, most recently from 2c7f3ae to 0dcdec8 Compare November 22, 2022 15:46
@rwhogg rwhogg changed the title feat!(dependencies): Upgrade to google-cloud-datastore 2.x feat(dependencies)!: Upgrade to google-cloud-datastore 2.x Nov 22, 2022
@rwhogg rwhogg force-pushed the bump-deps branch 2 times, most recently from 1fe5828 to e61cafa Compare November 29, 2022 17:41
@rwhogg rwhogg marked this pull request as ready for review November 29, 2022 17:41
@rwhogg rwhogg requested review from a team as code owners November 29, 2022 17:41
This was referenced Nov 29, 2022
Closed
Closed
rwhogg
rwhogg commented Nov 29, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@parthea parthea added the semver: major Hint for users that this is an API breaking change. label Nov 29, 2022
@smittysmee
Copy link

When are we thinking this will go out? I got a slew of pending tickets being held up by this PR :)

@snarfed snarfed mentioned this pull request Dec 4, 2022
Closed
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 5, 2022
@parthea parthea requested a review from Mariatta December 5, 2022 17:32
rwhogg
rwhogg commented Dec 5, 2022
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@rwhogg
feat(dependencies)!: Upgrade to google-cloud-datastore >= 2.7.2
15c2ddc 
This is the first version of google-cloud-datastore that does
not support Python 3.6, which aligns it with our supported
versions.

Also upgrade some other minimum dependencies to align.

BREAKING CHANGE: If you are using both the NDB and the
base google-cloud-datastore classes in your codebase,
you will have to update your use of those
google-cloud-datastore classes. See
https://github.com/googleapis/python-datastore/blob/main/UPGRADING.md
for recommendations for upgrading to google-cloud-datastore 2.x.

tweak deps
@rwhogg
fix: Update module imports
e2e8bfc
@smittysmee
Copy link

@rwhogg - why the minor version change on your setup.py but the major tag?

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 6, 2022
@parthea parthea assigned rwhogg and unassigned Mariatta Dec 6, 2022
@rwhogg
Copy link
Contributor Author

rwhogg commented Dec 6, 2022

why the minor version change on your setup.py but the major tag?

@smittysmee we're treating this as a major change as the upgrade to the new major version of google-cloud-datastore may require code changes by users to adapt to it. (A user might be using both NDB and google-cloud-datastore directly in the same application for instance). This will also align NDB with google-cloud-datastore better; the major version of NDB will match the major version of google-cloud-datastore that it uses.

https://github.com/googleapis/release-please will handle making a new major release for us 😺

@parthea parthea merged commit 12bbcb5 into googleapis:main Dec 6, 2022
@parthea parthea added the release-please:force-run To run release-please label Dec 6, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 6, 2022
@snarfed
Copy link

snarfed commented Dec 6, 2022

@rwhogg et al, for simple ndb users who aren't also using google-cloud-datastore directly, do you have any other suggestions for how to test our compatibility with this upgrade?

@rwhogg rwhogg deleted the bump-deps branch December 6, 2022 19:49
@rwhogg
Copy link
Contributor Author

rwhogg commented Dec 6, 2022

I'd recommend following the instructions from https://cloud.google.com/appengine/docs/standard/python3/migrating-to-cloud-ndb#testing and https://cloud.google.com/appengine/docs/standard/python3/migrating-to-cloud-ndb#deploying .

@snarfed
Copy link

snarfed commented Dec 6, 2022

It's working great so far!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees

@rwhogg rwhogg

Labels
api: datastore Issues related to the googleapis/python-ndb API. semver: major Hint for users that this is an API breaking change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependencies are out of date
5 participants
@rwhogg @smittysmee @snarfed @parthea @Mariatta