refactor(deps): remove stream-events dependency #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shaffeeullah
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Looks straightforward enough! @danielbankhead pls take a look as well though
ddelgrosso1
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ddelgrosso1
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Comment on lines
+172
to
+173
| private shouldEmitReading = true; | ||
| private shouldEmitWriting = true; |
There was a problem hiding this comment.
Looking at this further, 'reading' and 'writing' are called on every _read and _write event - to be fully backwards-compatible this class should do the same
There was a problem hiding this comment.
Ah good catch, I misread the stream-events / stubs code. Will fix.
There was a problem hiding this comment.
Actually I do believe it is only called once: https://github.com/stephenplusplus/stubs/blob/580b4d8b3a34c1193d5ec10e0db0d6ea4b4c0ec5/index.js#L30 it looks like after the number of calls is exhausted we revert to the cached function and stream-events would stop emitting reading / writing.
ddelgrosso1
force-pushed
the
remove-stream-events
branch
from
6a62184
to
46494ce
Compare
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
danielbankhead
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1916 馃