Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use require to load proto JSON #1283

Merged
merged 2 commits into from May 10, 2021
Merged

fix: use require to load proto JSON #1283

merged 2 commits into from May 10, 2021

Conversation

alexander-fenster
Copy link
Member

Fixes #1246.

Regenerating the code using gapic-generator-typescript v1.3.2. The main change is introduced in googleapis/gapic-generator-typescript#861. The generated proto changes are related to the changes in oneof field default values (that should be unset), that was introduced by protobufjs/protobuf.js#1597 and is unrelated to the proto JSON require problem.

@alexander-fenster alexander-fenster requested review from a team as code owners May 8, 2021 03:33
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2021
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label May 8, 2021
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #1283 (ae17ea3) into master (09c428a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
- Coverage   97.84%   97.84%   -0.01%     
==========================================
  Files          26       26              
  Lines       12700    12738      +38     
  Branches      558      605      +47     
==========================================
+ Hits        12426    12463      +37     
- Misses        268      269       +1     
  Partials        6        6              
Impacted Files Coverage Δ
src/publisher/index.ts 97.64% <100.00%> (+0.24%) ⬆️
src/publisher/message-batch.ts 100.00% <100.00%> (ø)
src/publisher/message-queues.ts 98.81% <100.00%> (+0.10%) ⬆️
src/topic.ts 98.66% <100.00%> (+0.02%) ⬆️
src/v1/publisher_client.ts 97.71% <100.00%> (-0.03%) ⬇️
src/v1/schema_service_client.ts 97.56% <100.00%> (-0.03%) ⬇️
src/v1/subscriber_client.ts 98.19% <100.00%> (-0.02%) ⬇️
src/pubsub.ts 99.46% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3dee854...ae17ea3. Read the comment docs.

@feywind feywind merged commit 201a56c into master May 10, 2021
@feywind feywind deleted the json-require branch May 10, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error running with webpack: ENOENT: no such file or directory, open 'iam_service.json'
2 participants