Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove test that depended on protobufjs error, now protobufjs correctly fails not finding the import #483

Merged
merged 7 commits into from Feb 21, 2024

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Feb 16, 2024

@sofisl sofisl requested a review from a team as a code owner February 16, 2024 23:25
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 16, 2024
@sofisl sofisl changed the title chore: update package.json chore: remove test that depended on protobufjs error, now it protobufjs correctly fails not finding the error Feb 20, 2024
@sofisl sofisl changed the title chore: remove test that depended on protobufjs error, now it protobufjs correctly fails not finding the error chore: remove test that depended on protobufjs error, now protobufjs correctly fails not finding the import Feb 20, 2024
@sofisl sofisl merged commit 988c07e into main Feb 21, 2024
18 checks passed
@sofisl sofisl deleted the sofisl-patch-1 branch February 21, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loadSync: should not be able to load test file using protobufjs directly failed
2 participants