Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update with generated code from protobufjs version 7.0.0 #1767

Closed
wants to merge 5 commits into from
Closed

fix: Update with generated code from protobufjs version 7.0.0 #1767

wants to merge 5 commits into from

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented Sep 7, 2022 •
edited

This is the result of running update.sh script .... I am very confused as to purpose of this script, since it appears to overlap googleapis-gen.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Sep 7, 2022
@tom-andersen tom-andersen changed the title Tomandersen/run update proto script fix: Update with generated code from protobufjs version 7.0.0 Sep 7, 2022
@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@tom-andersen tom-andersen marked this pull request as ready for review September 7, 2022 20:21
@tom-andersen tom-andersen requested review from a team as code owners September 7, 2022 20:21
@tom-andersen tom-andersen added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 7, 2022
@dconeybe dconeybe assigned tom-andersen and unassigned dconeybe Sep 7, 2022
@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 7, 2022
dconeybe
dconeybe requested changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@dconeybe dconeybe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm withdrawing my approval because we don't want stuff from the googleapis preview branch going into the main branch of this repo.

@alexander-fenster
Copy link
Contributor

To give you some context, the initial idea of update.sh was to split protos into smaller files, and load them separately as needed, which should improve cold start time. This is a unique thing, no other client libraries do this. I haven't looked at why the preview features get included though, the script might need some fixing. Feel free to ping me if you want extra 👀 to look at it.

alexander-fenster
alexander-fenster reviewed Sep 16, 2022
View reviewed changes
dev/protos/update.sh
@@ -38,7 +38,7 @@ PBTS="$(npm bin)/pbts"
pushd "$WORK_DIR"

# Clone necessary git repos.
git clone --depth 1 https://github.com/googleapis/googleapis.git
git clone -b preview --depth 1 https://github.com/googleapis/googleapis.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why -b preview?

@alexander-fenster
Copy link
Contributor

In #1765 I updated protos with the latest updates from googleapis. I'm assuming this PR could be closed now.

@tom-andersen tom-andersen deleted the tomandersen/runUpdateProtoScript branch September 16, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster left review comments

@dconeybe dconeybe dconeybe requested changes

Assignees

@tom-andersen tom-andersen

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tom-andersen @alexander-fenster @dconeybe