Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(converter): correct spelling of error message #1739

Merged
merged 4 commits into from Oct 7, 2022
Merged

chore(converter): correct spelling of error message #1739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
997e9e7
chore(converter): correct spelling of error message
mamichels Jun 22, 2022
52f9d74
Merge branch 'main' into chore/converter_typo
dconeybe Sep 8, 2022
04d0759
Merge branch 'main' into chore/converter_typo
mamichels Sep 12, 2022
a4b872c
Merge branch 'main' into chore/converter_typo
tom-andersen Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/src/convert.ts
View file
Open in desktop
Expand Up @@ -154,7 +154,7 @@ export function detectValueType(proto: ProtobufJsValue): string {

if (detectedValues.length !== 1) {
throw new Error(
`Unable to infer type value fom '${JSON.stringify(proto)}'.`
`Unable to infer type value from '${JSON.stringify(proto)}'.`
);
}

Expand Down
4 changes: 2 additions & 2 deletions dev/test/index.ts
View file
Open in desktop
Expand Up @@ -817,7 +817,7 @@ describe('snapshot_() method', () => {
'1970-01-01T00:00:05.000000006Z',
'json'
);
}).to.throw("Unable to infer type value fom '{}'.");
}).to.throw("Unable to infer type value from '{}'.");

expect(() => {
firestore.snapshot_(
Expand All @@ -831,7 +831,7 @@ describe('snapshot_() method', () => {
'json'
);
}).to.throw(
'Unable to infer type value fom \'{"stringValue":"bar","integerValue":42}\'.'
'Unable to infer type value from \'{"stringValue":"bar","integerValue":42}\'.'
);

expect(() => {
Expand Down