Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tests will now verify asynchronous termination of underlying steam, and fix related bug. #1772

Merged
merged 3 commits into from Sep 15, 2022

Conversation

tom-andersen
Copy link
Contributor

No description provided.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 14, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Sep 14, 2022
@tom-andersen tom-andersen force-pushed the tomandersen/fixClosingOfConnection branch from 6b6e4c6 to d709194 Compare September 14, 2022 14:07
@tom-andersen tom-andersen force-pushed the tomandersen/fixClosingOfConnection branch from d709194 to 407df2e Compare September 14, 2022 14:10
@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 14, 2022
@tom-andersen tom-andersen marked this pull request as ready for review September 14, 2022 14:11
@tom-andersen tom-andersen requested review from a team as code owners September 14, 2022 14:11
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Thanks for the fix.

dev/test/query.ts Show resolved Hide resolved
dev/src/reference.ts Show resolved Hide resolved
@tom-andersen tom-andersen merged commit a1717ff into main Sep 15, 2022
@tom-andersen tom-andersen deleted the tomandersen/fixClosingOfConnection branch September 15, 2022 18:46
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 26, 2022
🤖 I have created a release *beep* *boop*
---


## [6.3.0](v6.2.0...v6.3.0) (2022-09-22)


### Features

* Add aggregation query APIs ([#1765](#1765)) ([18be4d0](18be4d0))


### Bug Fixes

* Tests will now verify asynchronous termination of underlying steam, and fix related bug. ([#1772](#1772)) ([a1717ff](a1717ff))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants