fix: Tests with termination of underlying steam

googleapis · Sep 14, 2022 · 407df2e · 407df2e
1 parent 6393fe7
commit 407df2e
Show file tree

Hide file tree

Showing 6 changed files with 134 additions and 68 deletions.
diff --git a/dev/src/reference.ts b/dev/src/reference.ts
@@ -2285,7 +2285,9 @@ export class Query<T = firestore.DocumentData> implements firestore.Query<T> {
           if (proto.done) {
             logger('Query._stream', tag, 'Trigger Logical Termination.');
             backendStream.unpipe(stream);
-            stream.emit('end');
+            backendStream.resume();
+            backendStream.end();
+            stream.end();
           }
         } else {
           callback(undefined, {readTime});

diff --git a/dev/test/bulk-writer.ts b/dev/test/bulk-writer.ts
@@ -188,8 +188,8 @@ describe('BulkWriter', () => {
     });
   }
 
-  afterEach(() => {
-    verifyInstance(firestore);
+  afterEach(async () => {
+    await verifyInstance(firestore);
     setTimeoutHandler(setTimeout);
   });
 

diff --git a/dev/test/partition-query.ts b/dev/test/partition-query.ts
@@ -86,8 +86,8 @@ describe('Partition Query', () => {
     });
   });
 
-  afterEach(() => {
-    verifyInstance(firestore);
+  afterEach(async () => {
+    await verifyInstance(firestore);
     setTimeoutHandler(setTimeout);
   });