Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(converter): correct spelling of error message #1739

Merged
merged 4 commits into from Oct 7, 2022

Conversation

mamichels
Copy link
Contributor

Hi,

it ain't much but it's honest work.
Does not break or fix anything so I skipped the issue creation part here. If still required, ping me.

@mamichels mamichels requested review from a team as code owners June 22, 2022 22:12
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jun 22, 2022
@dconeybe dconeybe self-assigned this Sep 8, 2022
@PurHur
Copy link

PurHur commented Sep 8, 2022

Could you please provide internationalization for the error messages?

@dconeybe
Copy link
Contributor

dconeybe commented Sep 8, 2022

@PurHur

Could you please provide internationalization for the error messages?

Do you mean translating the error messages to other languages? If so, that is not something we will be doing. All of our error messages will be in English only.

@tom-andersen tom-andersen added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 7, 2022
@tom-andersen tom-andersen added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2022
@tom-andersen tom-andersen added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 7, 2022
@tom-andersen tom-andersen merged commit 973a199 into googleapis:main Oct 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. kokoro:run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants