Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: call java_client:execute from executeUpdate #896

Closed

Conversation

rajatbhatta
Copy link
Contributor

Throw an exception if the query passed into executeUpdate returns a ResultSet. We call the java_client:execute API to check the actual result of the query, and then throw an exception if the returned value is a ResultSet.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Jun 10, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jul 18, 2022
@rajatbhatta
Copy link
Contributor Author

Closing this PR in favour of #936.

@rajatbhatta rajatbhatta deleted the dml-returning-changes branch August 30, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant