Skip to content

Commit

Permalink
deps: fixing the test scope dependency to runtime (#1742)
Browse files Browse the repository at this point in the history
Fixing the test-scope dependency to runtime. The flatten maven plugin does not interpret test scope dependency correctly.

The test scope was added recently: https://github.com/googleapis/java-bigquerystorage/pull/1720/files#diff-273690ed1fb8c3821089309482b75cb6b6de18d07238cb82c74cb1855e215904 . This would cause problem like googleapis/java-pubsub#1239
  • Loading branch information
suztomo committed Aug 9, 2022
1 parent a8b1d32 commit 878020b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.md
Expand Up @@ -56,13 +56,13 @@ implementation 'com.google.cloud:google-cloud-bigquerystorage'
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.cloud:google-cloud-bigquerystorage:2.19.0'
implementation 'com.google.cloud:google-cloud-bigquerystorage:2.19.1'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-bigquerystorage" % "2.19.0"
libraryDependencies += "com.google.cloud" % "google-cloud-bigquerystorage" % "2.19.1"
```

## Authentication
Expand Down
2 changes: 1 addition & 1 deletion google-cloud-bigquerystorage/pom.xml
Expand Up @@ -181,7 +181,7 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-core</artifactId>
<scope>test</scope>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
Expand Down

0 comments on commit 878020b

Please sign in to comment.