Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jetty to 9.4 #432

Closed
wants to merge 3 commits into from

Conversation

ericraskin
Copy link
Contributor

fix: Fixes #397 - for compatibility with Jetty 9.4 applications

@ericraskin ericraskin requested a review from a team as a code owner February 16, 2020 16:48
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 16, 2020
@ericraskin
Copy link
Contributor Author

ericraskin commented Feb 16, 2020 via email

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 16, 2020
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code appears correct. The reason I'm not approving is that I have concerns where it is being used currently. I don't believe we have any Jetty 8 in use anymore, but I want to check before approval.

@lesv lesv added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 17, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 17, 2020
…er instead.

The original code was dependent on version 8.2 of Jetty. There was a breaking change after 8.2 so that this code would not work with more recent Jetty version (specifically 9.4).  Removing the dependency on Jetty removes this incompatibility.
@ericraskin
Copy link
Contributor Author

Posting a new pull request replacing Jetty with HttpServer. Maybe this will work better. Should I leave this open or close it?

@ericraskin ericraskin closed this Feb 18, 2020
@ericraskin ericraskin deleted the update-jetty-to-9.4 branch February 18, 2020 15:15
@ericraskin ericraskin restored the update-jetty-to-9.4 branch February 18, 2020 15:22
@ericraskin ericraskin deleted the update-jetty-to-9.4 branch February 18, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google-oauth-client-jetty incompatible with Jetty 9.4+
4 participants