Updated for v9.4 of Jetty #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
googlebot
added
the
cla: no
elharo
reviewed
Feb 16, 2020
| @@ -89,6 +89,7 @@ | |||
| <dependency> | |||
| <groupId>org.eclipse.jetty</groupId> | |||
| <artifactId>jetty-server</artifactId> | |||
| <version>9.4.26.v20200117</version> | |||
There was a problem hiding this comment.
versions are set elsewhere.
There was a problem hiding this comment.
I'm new to this. How are versions set? There are a number of people who need this upgrade (see the Issue). And why don't you want it? Help me understand so I can do a better job.
There was a problem hiding this comment.
OK - I found where the versions are set and I will update my fix appropriately. Is a new pull request appropriate or will it be rejected because the upgrade is not wanted (why not)?
There was a problem hiding this comment.
Jetty is a weird dep and we need to keep it consistent across the orbit of all GCP libraries, not just in this one project. Upgrading it to a new major version is going to require some planning and investigation to make sure we don't accidentally break anything. If this is necessary for some reason, please file an issue with more details so this can be prioritized and discussed.
|
Oh, I see. An issue was already opened:
#397. This
patch resolves the issue when tested locally.
In my particular case, I am using Cuba Platform and deploying what they
call an UberJar for my applications. Their UberJar embeds Jetty 9.4 into
the jar file so that it can be run standalone.
My application is trying to interface to Gmail using the OAuth2 client
(google-oauth-client), which is written for Jetty 8.2.
There was a breaking change between 8.2 and 9.4 regarding the way servers
and connections are created (specifically the setHost) call. My patch
updates the LocalServerReceiver code in the google-oauth-client-jetty
package to work with the new setHost calls.
…On Sun, Feb 16, 2020 at 12:16 PM Elliotte Rusty Harold < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In google-oauth-client-jetty/pom.xml
<#431 (comment)>
:
> @@ -89,6 +89,7 @@
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-server</artifactId>
+ <version>9.4.26.v20200117</version>
Jetty is a weird dep and we need to keep it consistent across the orbit of
all GCP libraries, not just in this one project. Upgrading it to a new
major version is going to require some planning and investigation to make
sure we don't accidentally break anything. If this is necessary for some
reason, please file an issue with more details so this can be prioritized
and discussed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#431?email_source=notifications&email_token=ABVKI2FP2SCTQ7QIUWZTG4LRDFYE3A5CNFSM4KWEQJH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVWEIMA#discussion_r379918442>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVKI2DCHOOTQHBITEJO2KDRDFYE3ANCNFSM4KWEQJHQ>
.
--
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Eric H. Raskin
914-765-0500 x120 or *315-338-4461
(direct)*
Professional Advertising Systems Inc.
fax: 914-765-0500 or *315-338-4461 (direct)*
200 Business Park Drive Suite 304
eraskin@paslists.com
Armonk, NY 10504
http://www.paslists.com
|
|
We probably should update. However it's not just this repo that needs to move at the same time. There are several dozen other repos we need to update in rough sync, and several hundred other artifacts. And we need to figure out if that's likely to break any dependent projects that rely on this being 8.2. Step 1 is simply to figure out which of those several hundred other artifacts need to move and how big a change that will be for them. I do wonder if it might be simpler to remove the jetty dependency completely and use com.sun.net.httpserver instead. That's a bigger change but it has much less risk of introducing dependency conflicts with other projects. |
|
I just placed a replacement pull request, doing as you asked. I have
replaced Jetty with HttpServer. Seems to work fine for me and passes the
built-in tests.
…On Sun, Feb 16, 2020 at 1:38 PM Elliotte Rusty Harold < ***@***.***> wrote:
We probably should update. However it's not just this repo that needs to
move at the same time. There are several dozen other repos we need to
update in rough sync, and several hundred other artifacts. And we need to
figure out if that's likely to break any dependent projects that rely on
this being 8.2.
Step 1 is simply to figure out which of those several hundred other
artifacts need to move and how big a change that will be for them. I do
wonder if it might be simpler to remove the jetty dependency completely and
use com.sun.net.httpserver instead. That's a bigger change but it has much
less risk of introducing dependency conflicts with other projects.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#431?email_source=notifications&email_token=ABVKI2DW4RMLGZUYZM2ZQ63RDGBZXA5CNFSM4KWEQJH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4OUGA#issuecomment-586738200>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVKI2F4SF3QJULKRBFWGKDRDGBZXANCNFSM4KWEQJHQ>
.
--
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Eric H. Raskin
914-765-0500 x120 or *315-338-4461
(direct)*
Professional Advertising Systems Inc.
fax: 914-765-0500 or *315-338-4461 (direct)*
200 Business Park Drive Suite 304
eraskin@paslists.com
Armonk, NY 10504
http://www.paslists.com
|
|
Oh - forgot to mention - the package name unfortunately still contains
"jetty". Changing that would break the jar name, which would probably
break a lot of code. Open to suggestions.
…On Tue, Feb 18, 2020 at 11:27 AM Eric Raskin ***@***.***> wrote:
I just placed a replacement pull request, doing as you asked. I have
replaced Jetty with HttpServer. Seems to work fine for me and passes the
built-in tests.
On Sun, Feb 16, 2020 at 1:38 PM Elliotte Rusty Harold <
***@***.***> wrote:
> We probably should update. However it's not just this repo that needs to
> move at the same time. There are several dozen other repos we need to
> update in rough sync, and several hundred other artifacts. And we need to
> figure out if that's likely to break any dependent projects that rely on
> this being 8.2.
>
> Step 1 is simply to figure out which of those several hundred other
> artifacts need to move and how big a change that will be for them. I do
> wonder if it might be simpler to remove the jetty dependency completely and
> use com.sun.net.httpserver instead. That's a bigger change but it has much
> less risk of introducing dependency conflicts with other projects.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#431?email_source=notifications&email_token=ABVKI2DW4RMLGZUYZM2ZQ63RDGBZXA5CNFSM4KWEQJH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL4OUGA#issuecomment-586738200>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABVKI2F4SF3QJULKRBFWGKDRDGBZXANCNFSM4KWEQJHQ>
> .
>
--
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Eric H. Raskin
914-765-0500 x120 or *315-338-4461
(direct)*
Professional Advertising Systems Inc.
fax: 914-765-0500 or *315-338-4461 (direct)*
200 Business Park Drive Suite 304
***@***.***
Armonk, NY 10504
http://www.paslists.com
--
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Eric H. Raskin
914-765-0500 x120 or *315-338-4461
(direct)*
Professional Advertising Systems Inc.
fax: 914-765-0500 or *315-338-4461 (direct)*
200 Business Park Drive Suite 304
eraskin@paslists.com
Armonk, NY 10504
http://www.paslists.com
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fixes #397. Update to Jetty 9.4.v26.20200117