Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ProGuard rules for this library #1093

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Goooler
Copy link

@Goooler Goooler commented Dec 14, 2023

Add ProGuard/R8 keep rules to ensure this lib will be compatible with obfuscation enabled, the files under src/main/resources/META-INF/proguard should be interpreted by R8 automatically.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@Goooler Goooler requested review from a team as code owners December 14, 2023 02:37
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 14, 2023
Add ProGuard/R8 keep rules to ensure this lib will be compatible with obfuscation enabled, the files under `src/main/resources/META-INF/proguard` should be interpreted by R8 automatically.
@Goooler Goooler changed the title Add ProGuard rules for this library chore: add ProGuard rules for this library Dec 14, 2023
@Goooler
Copy link
Author

Goooler commented Dec 14, 2023

Actually, we can just keep a few classes under com.google.api.client.auth instead of all of them, but I have no more time to investigate that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant