Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update ci.yaml for Java 21 unit testing #1086

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

chore: Update ci.yaml for Java 21 unit testing #1086

wants to merge 11 commits into from

Conversation

ddixit14
Copy link
Contributor

@ddixit14 ddixit14 commented Dec 1, 2023

No description provided.

@ddixit14 ddixit14 requested review from a team as code owners December 1, 2023 18:28
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 1, 2023
@ddixit14
Copy link
Contributor Author

ddixit14 commented Dec 5, 2023

ci / units (21) (pull_request) failing with:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project google-oauth-client: Compilation failure: Compilation failure: 
Error: [ERROR] error: Source option 7 is no longer supported. Use 8 or later.
Error: [ERROR] error: Target option 7 is no longer supported. Use 8 or later.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Dec 5, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Dec 6, 2023
@suztomo
Copy link
Member

suztomo commented Dec 6, 2023 •
edited

How about "Compile with Java 8 and run tests in Java 21"? We want to ensure that the libraries published from this repository are compatible with Java 21 users.

The sdk-platform-java repository has "Compile with Java 17 and run tests with Java 8" in
https://github.com/googleapis/sdk-platform-java/blob/main/.github/workflows/ci.yaml#L74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddixit14 @suztomo