Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix signature test #1055

Merged
merged 1 commit into from
Jun 6, 2023
Merged

test: fix signature test #1055

merged 1 commit into from
Jun 6, 2023

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jun 5, 2023

Use the mock http transport to stub the public key fetching from https://www.googleapis.com/oauth2/v3/certs. Traditionally, these public keys have not rotated (often). For the unit test, we lock the time (for timestamp expiry) and the existing public keys at this point in time.

@chingor13 chingor13 requested review from a team as code owners June 5, 2023 22:05
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jun 5, 2023
@chingor13
Copy link
Contributor Author

Note: will fix the lint in a follow-up PR.

@chingor13 chingor13 requested a review from suztomo June 5, 2023 23:22
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test passed

Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks )

@chingor13 chingor13 merged commit 66e0e05 into main Jun 6, 2023
15 of 16 checks passed
@chingor13 chingor13 deleted the fix-signature-test branch June 6, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants