feat: Update dependencies, adapt tooling and regenerate #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: eventarc
amanda-tarafa
approved these changes
Apr 3, 2024
| var suffix = type.Split('.').Last(); | ||
| // Firestore and Datastore have separate "withAuthContext" variants; in those cases we want to | ||
| // use the previous segment as well. Hard-coding this isn't pleasant, but it'll do until we see | ||
| // anythign else we need to do. |
There was a problem hiding this comment.
tiny typo: anythign => anything
There was a problem hiding this comment.
Whoops, thanks - will fix in the morning.
| .Last(); | ||
| // "Undo" the hack before to get back to the relevant part of the type. | ||
| // (We can't just use type.Split('.').Last(), as that would just give us "withAuthContext".) | ||
| var description = suffix.Replace("WithAuthContext", ".withAuthContext"); |
There was a problem hiding this comment.
description is now foo.withAuthContext, just making sure that's intended.
There was a problem hiding this comment.
Yup, that's correct. (If you have a look in the context of the other constants, I think that's probably the best option.)
- New events for APIs: Batch, Deploy, NetworkServices, Speech - Additional event types for Firestore and Datastore
This is just a matter of new codegen in protoc, with better debugger display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(One commit at a time...)