Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [AnalyticsAdmin] update client libraries to support Database operations #4975

Merged
merged 2 commits into from Jan 28, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 5, 2022

  • Regenerate this pull request now.

PiperOrigin-RevId: 419710013

Source-Link: googleapis/googleapis@b7c9d05

Source-Link: https://github.com/googleapis/googleapis-gen/commit/ae498279c4e71cd4aa6e0655e92a693df97472c4
Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6ImFlNDk4Mjc5YzRlNzFjZDRhYTZlMDY1NWU5MmE2OTNkZjk3NDcyYzQifQ==

@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners January 5, 2022 09:00
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 5, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2022
@bshaffer bshaffer closed this Jan 7, 2022
@bshaffer
Copy link
Contributor

bshaffer commented Jan 7, 2022

closing to see if owlbot will regenerate

@bshaffer bshaffer changed the title feat: update client libraries to support Database operations feat: [AnalyticsAdmin] update client libraries to support Database operations Jan 7, 2022
@bshaffer bshaffer reopened this Jan 7, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 7, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 7, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2022
@@ -157,7 +157,7 @@ public function setCreateTime($var)
*/
public function getUpdateTime()
{
return isset($this->update_time) ? $this->update_time : null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update is from protocolbuffers/protobuf#8670

* @return bool
*/
public function getIsDeletable()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because this method was removed

@gcf-owl-bot
Copy link
Contributor Author

gcf-owl-bot bot commented Jan 27, 2022

Owl bot is regenerating pull request 4975...
Build name: OTQyNDQyOWQtMzIyYi00YjEwLTgzMzYtNGNhZmEyZDhjMTBm

PiperOrigin-RevId: 419710013

Source-Link: googleapis/googleapis@b7c9d05

Source-Link: googleapis/googleapis-gen@ae49827
Copy-Tag: eyJwIjoiQW5hbHl0aWNzQWRtaW4vLk93bEJvdC55YW1sIiwiaCI6ImFlNDk4Mjc5YzRlNzFjZDRhYTZlMDY1NWU5MmE2OTNkZjk3NDcyYzQifQ==
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-48528beb-f108-4cc5-a9e7-958fd61e9b7d branch from 6341299 to 26c4388 Compare January 27, 2022 23:21
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2022
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 27, 2022
*
* @experimental
*/
public static function enhancedMeasurementSettingsName($property, $webDataStream)
Copy link
Contributor

@bshaffer bshaffer Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method was removed, but we're in beta so it's "ok"

*
* @throws ApiException if the remote call fails
*
* @experimental
*/
public function getEnhancedMeasurementSettings($name, array $optionalArgs = [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method was removed, but we're in beta so it's "ok"

*
* @throws ApiException if the remote call fails
*
* @experimental
*/
public function updateFirebaseLink($firebaseLink, $updateMask, array $optionalArgs = [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method was removed, but we're in beta so it's "ok"

*
* @throws ApiException if the remote call fails
*
* @experimental
*/
public function updateEnhancedMeasurementSettings($enhancedMeasurementSettings, $updateMask, array $optionalArgs = [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method was removed but we're in beta so it's "ok"

@bshaffer bshaffer merged commit ab44e61 into master Jan 28, 2022
@bshaffer bshaffer deleted the owl-bot-48528beb-f108-4cc5-a9e7-958fd61e9b7d branch January 28, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants