feat(pubsub): enable project autodetection and detect empty project #8168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
shollyman
approved these changes
Jun 26, 2023
marwanad
reviewed
Sep 8, 2023
| // NewClient creates a new PubSub client. It uses a default configuration. | ||
| func NewClient(ctx context.Context, projectID string, opts ...option.ClientOption) (c *Client, err error) { | ||
| return NewClientWithConfig(ctx, projectID, nil, opts...) | ||
| } | ||
|
|
||
| // NewClientWithConfig creates a new PubSub client. | ||
| func NewClientWithConfig(ctx context.Context, projectID string, config *ClientConfig, opts ...option.ClientOption) (c *Client, err error) { | ||
| if projectID == "" { |
There was a problem hiding this comment.
@hongalex doesn't having this check early on break the opts.WithoutAuthentication case since it now requires you to pass a dummy projectID to instantiate the clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows autodetection of project ID when the sentinel value (DetectProjectID) is passed in to
pubsub.NewClient. This uses thedetect, similar to BigQuery in #4312. Similar to Firestore in #4299, empty project IDs will now return an error.Also exposes a new method in pubsub client
client.Project()which returns the project ID.Retrieving information about the topic's (and subscription) project ID can be done by
topic.Config, followed by callingconfig.String().Addresses pubsub portion in #1294
Fixes #3828