Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix apidiff handling of empty set #6912

Merged
merged 19 commits into from Oct 24, 2022
Merged

chore(ci): fix apidiff handling of empty set #6912

Changes from 3 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b1ce7af
chore(ci): fix apidiff handling of empty set
noahdietz Oct 24, 2022
07b1b9c
maybe fix syntax
noahdietz Oct 24, 2022
34d6890
maybe fix syntax
noahdietz Oct 24, 2022
82543b1
inline gitfu
noahdietz Oct 24, 2022
a15711e
add missing cat
noahdietz Oct 24, 2022
4bbc0a6
maybe fix syntax
noahdietz Oct 24, 2022
344160d
TEST
noahdietz Oct 24, 2022
6c07012
Revert "TEST"
noahdietz Oct 24, 2022
e072984
maybe fix syntax
noahdietz Oct 24, 2022
d28c5d5
try a skip var
noahdietz Oct 24, 2022
d87a064
Revert "Revert "TEST""
noahdietz Oct 24, 2022
5f76216
fix non-skip case
noahdietz Oct 24, 2022
f1d23f9
Revert "Revert "Revert "TEST"""
noahdietz Oct 24, 2022
47b7144
Merge branch 'main' into fix-apidiff
noahdietz Oct 24, 2022
e34058b
Merge branch 'main' into fix-apidiff
noahdietz Oct 24, 2022
9d1da70
Merge branch 'main' into fix-apidiff
gcf-merge-on-green[bot] Oct 24, 2022
af31f4f
Merge branch 'main' into fix-apidiff
noahdietz Oct 24, 2022
5bb54ef
Merge branch 'main' into fix-apidiff
gcf-merge-on-green[bot] Oct 24, 2022
163cc52
Merge branch 'main' into fix-apidiff
gcf-merge-on-green[bot] Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/apidiff.yml
View file
Open in desktop
Expand Up @@ -34,7 +34,7 @@ jobs:
apidiff:
needs: scan_changes
runs-on: ubuntu-latest
if: "!contains(github.event.pull_request.labels.*.name, 'breaking change allowed')"
if: ${{ needs.scan_changes.outputs.changed_dirs != '[]' }} && !contains(github.event.pull_request.labels.*.name, 'breaking change allowed')
continue-on-error: true
strategy:
matrix: ${{ fromJson(needs.scan_changes.outputs.changed_dirs) }}
Expand Down