Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(pubsub): fix comments on message for exactly once delivery #6878

Merged
merged 3 commits into from Oct 17, 2022
Merged

docs(pubsub): fix comments on message for exactly once delivery #6878

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02bd12b
docs(pubsub): fix comments on message for exactly once delivery
hongalex Oct 17, 2022
d5ed583
Merge branch 'main' into fix-message-docs
hongalex Oct 17, 2022
e9d10cd
Merge branch 'main' into fix-message-docs
hongalex Oct 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions pubsub/message.go
View file
Open in desktop
Expand Up @@ -37,8 +37,10 @@ import (
//
// If using exactly once delivery, you should call Message.AckWithResult and
// Message.NackWithResult instead. These methods will return an AckResult,
// which you should wait on to obtain the status of the Ack/Nack to ensure
// these were properly processed by the server. If not,
// which tracks the state of acknowledgement operation. If the AckResult returns
// successful, the message is guaranteed NOT to be re-delivered. Otherwise,
// the AckResult will return an error with more details about the failure
// and the message may be re-delivered.
type Message = ipubsub.Message

// msgAckHandler performs a safe cast of the message's ack handler to psAckHandler.
Expand Down