Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storage): add scenario 7 to retry conformance tests #6684

Merged
merged 5 commits into from Sep 22, 2022
Merged

test(storage): add scenario 7 to retry conformance tests #6684

merged 5 commits into from Sep 22, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 15, 2022 •
edited

This adds scenario 7 to test resumable uploads can handle complex retries, per internal docs go/retry-conf-test-media-ops

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Sep 15, 2022
tritone
tritone reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Do we need a generated code update, or anything else other than updating the dependency on the apiary client? If not let's merge and get this out. :)

@cojenco cojenco marked this pull request as ready for review September 22, 2022 00:15
@cojenco cojenco requested review from a team as code owners September 22, 2022 00:15
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 22, 2022
tritone
tritone approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline, this looks good!

@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label Sep 22, 2022
@cojenco cojenco merged commit 2bc6566 into googleapis:main Sep 22, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cojenco @tritone @kokoro-team