Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): parse out project number if available #6671

Merged
merged 3 commits into from Sep 20, 2022

Conversation

noahdietz
Copy link
Contributor

The JSON API has a dedicated ProjectNumber uint64 field used to populate the same field on BucketAttrs. The gRPC API has a string project field that can contain either a project number or a project identifier (alphanumeric). Parse out the project number if it is present in the returned Bucket, otherwise leave it as 0.

@noahdietz noahdietz requested review from a team as code owners September 14, 2022 20:33
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the Cloud Storage API. labels Sep 14, 2022
@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 17cceeb into googleapis:main Sep 20, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2022
@noahdietz noahdietz deleted the parse-project-number branch September 20, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants