Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storage): increase timeout for ACL test retry #6618

Merged
merged 4 commits into from Sep 7, 2022
Merged

test(storage): increase timeout for ACL test retry #6618

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6c8322
test(storage): increase timeout for ACL test retry
tritone Sep 6, 2022
6ad87bd
Merge branch 'main' into acl-test-timeout
tritone Sep 7, 2022
d0148ed
Merge branch 'main' into acl-test-timeout
tritone Sep 7, 2022
e278a65
Merge branch 'main' into acl-test-timeout
tritone Sep 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions storage/integration_test.go
View file
Open in desktop
Expand Up @@ -4986,12 +4986,12 @@ func hasRule(acl []ACLRule, rule ACLRule) bool {
}

// retry retries a function call as well as an (optional) correctness check for up
// to 11 seconds. Both call and check must run without error in order to succeed.
// to 60 seconds. Both call and check must run without error in order to succeed.
// If the timeout is hit, the most recent error from call or check will be returned.
// This function should be used to wrap calls that might cause integration test
// flakes due to delays in propagation (for example, metadata updates).
func retry(ctx context.Context, call func() error, check func() error) error {
timeout := time.After(11 * time.Second)
timeout := time.After(60 * time.Second)
var err error
for {
select {
Expand Down