Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): typo on pubsub FlowControlSettings #6453

Merged
merged 2 commits into from Aug 2, 2022

Conversation

jinwoo1225
Copy link
Contributor

@jinwoo1225 jinwoo1225 commented Aug 1, 2022

Hi, I just found a typo on comments.

@jinwoo1225 jinwoo1225 requested review from a team as code owners August 1, 2022 11:56
@google-cla
Copy link

google-cla bot commented Aug 1, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 1, 2022
@hongalex
Copy link
Member

hongalex commented Aug 1, 2022

Hi, thanks for opening this pull request! Please accept the CLA and I'll be happy to get this merged in.

@hongalex hongalex changed the title fix: typo on pubsub FlowControlSettings fix(pubsub): typo on pubsub FlowControlSettings Aug 1, 2022
@jinwoo1225
Copy link
Contributor Author

I thought I just did cla agreement. Did I miss anything? it seems cla Github action looks great. ☺️

@hongalex
Copy link
Member

hongalex commented Aug 2, 2022

Oh, I just didn't refresh. Let me run CI and should be ready to merge after this. Thanks!

@hongalex hongalex added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 2, 2022
@hongalex hongalex enabled auto-merge (squash) August 2, 2022 01:20
@hongalex hongalex disabled auto-merge August 2, 2022 01:20
@hongalex hongalex enabled auto-merge (squash) August 2, 2022 01:20
@hongalex hongalex changed the title fix(pubsub): typo on pubsub FlowControlSettings docs(pubsub): typo on pubsub FlowControlSettings Aug 2, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 2, 2022
@hongalex hongalex merged commit 34d839e into googleapis:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants