Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery/storage/managedstorage): improve internal locking #6304

Merged
merged 10 commits into from
Jul 7, 2022
Merged

fix(bigquery/storage/managedstorage): improve internal locking #6304

merged 10 commits into from
Jul 7, 2022

Commits on Jul 4, 2022

  1. fix(bigquery/storage/managedwriter): address potential deadlocks 

    This PR addresses some potential deadlocks introduced as part of a refactor
of critical section code.  It adds a testing to help isolate deadlock code,
and makes a small change to the retry predicate to disallow retries of
context-based errors (cancelations/expirations).
    @shollyman
    shollyman committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    d9da248 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. refine testing, closure for closing as well

    @shollyman
    shollyman committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    8160a2b View commit details
    Browse the repository at this point in the history

  2. remote spurious logging

    @shollyman
    shollyman committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    a61cd41 View commit details
    Browse the repository at this point in the history

  3. simplify close

    @shollyman
    shollyman committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    33866f4 View commit details
    Browse the repository at this point in the history

  4. append() -> appendWithRetry(), closure -> lockingAppend()

    @shollyman
    shollyman committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    b042869 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fun-with-locking

    @shollyman
    shollyman committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    020b429 View commit details
    Browse the repository at this point in the history

  6. satisfy the linter

    @shollyman
    shollyman committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    c452627 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Merge branch 'main' into fun-with-locking

    @steffnay
    steffnay committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    c165f4e View commit details
    Browse the repository at this point in the history

  2. move context expiry check before the critical section

    @shollyman
    shollyman committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    a51fc1d View commit details
    Browse the repository at this point in the history

  3. move channel close adjacent to CloseSend

    @shollyman
    shollyman committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    d5332f0 View commit details
    Browse the repository at this point in the history