Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigquery/storage/managedwriter): address potential deadlocks #6279

Closed
wants to merge 1 commit into from
Closed

fix(bigquery/storage/managedwriter): address potential deadlocks #6279

wants to merge 1 commit into from

Conversation

shollyman
Copy link
Contributor

TODO: testing

Fixes: #6278

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the BigQuery API. labels Jun 29, 2022
@fsaintjacques
Copy link

fsaintjacques commented Jun 30, 2022 •
edited

Usage of defer for unlocking would reduce this problem occurring again due to refactor. The for loop in the append method could be wrapped in a closure and there the defer would not suffer from block-scope issues.

@shollyman
Copy link
Contributor Author

Closing this in favor of PR 6304.

@shollyman shollyman closed this Jul 5, 2022
@shollyman shollyman deleted the unlocks branch July 5, 2022 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigquery/storage/managedwriter: deadlocks due to locking changes
2 participants
@shollyman @fsaintjacques