Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery/storage/managedwriter): enable field name indirection #6247

Merged
merged 30 commits into from Oct 4, 2022
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2b8c0fd
feat(bigquery/storage/managedwriter): expose preview annotation
shollyman Jun 23, 2022
5d62198
Merge branch 'main' into annotation-preview
shollyman Jul 14, 2022
5f771fb
update schema normalization, add unit test
shollyman Jul 14, 2022
5bd5e87
Merge branch 'main' into annotation-preview
shollyman Jul 15, 2022
eb7d1e4
add validation test for column_name annotation
shollyman Jul 15, 2022
229f408
Merge branch 'main' into annotation-preview
shollyman Jul 15, 2022
2da5fac
Merge branch 'main' into annotation-preview
shollyman Jul 27, 2022
3c9737c
Merge branch 'main' into annotation-preview
shollyman Jul 28, 2022
3638ed4
Merge branch 'main' into annotation-preview
shollyman Aug 23, 2022
70390f8
update expectations - no emojis, sadly
shollyman Aug 23, 2022
9db8548
Merge branch 'main' into annotation-preview
shollyman Aug 24, 2022
ffbae4e
additional error checking
shollyman Aug 31, 2022
4fe1e57
Merge branch 'main' into annotation-preview
shollyman Sep 7, 2022
65a7f2a
use quoted literals in validation builder, cleanup extraneous logging
shollyman Sep 9, 2022
9f1a948
Merge branch 'main' into annotation-preview
shollyman Sep 9, 2022
6a5d804
switch emojis to valid characters in conversion tests
shollyman Sep 9, 2022
74d998a
Merge branch 'main' into annotation-preview
shollyman Sep 14, 2022
a651315
switch from preview to stable annotation
shollyman Sep 14, 2022
458bb2c
Merge branch 'main' into annotation-preview
shollyman Sep 15, 2022
2659053
switch field name encoding for unicode conversion
shollyman Sep 15, 2022
125bfea
Merge branch 'main' into annotation-preview
shollyman Sep 16, 2022
199d01a
address reviewer feedback re: allowed characters
shollyman Sep 16, 2022
08288f0
Merge branch 'main' into annotation-preview
shollyman Sep 20, 2022
b8a8044
remove stale test
shollyman Sep 21, 2022
cf81868
Merge branch 'main' into annotation-preview
shollyman Sep 21, 2022
d6428bc
rely on name validation directly from protobuf
shollyman Sep 21, 2022
4a12d9c
more test cases
shollyman Sep 21, 2022
6558136
disable indirection validation test until all test projects have access
shollyman Sep 21, 2022
83c0e25
Merge branch 'main' into annotation-preview
shollyman Oct 4, 2022
a059390
enable test
shollyman Oct 4, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 1 addition & 7 deletions bigquery/storage/managedwriter/adapt/protoconversion.go
Expand Up @@ -18,7 +18,6 @@ import (
"encoding/base64"
"fmt"
"strings"
"unicode"

storagepb "google.golang.org/genproto/googleapis/cloud/bigquery/storage/v1"
"google.golang.org/protobuf/proto"
Expand Down Expand Up @@ -348,12 +347,7 @@ func tableFieldSchemaToFieldDescriptorProto(field *storagepb.TableFieldSchema, i

// nameRequiresAnnotation determines whether a field name requires unicode-annotation.
func nameRequiresAnnotation(in string) bool {
for i := 0; i < len(in); i++ {
if in[i] > unicode.MaxASCII {
return true
}
}
return false
return !protoreflect.Name(in).IsValid()
shollyman marked this conversation as resolved.
Show resolved Hide resolved
}

// NormalizeDescriptor builds a self-contained DescriptorProto suitable for communicating schema
Expand Down