New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): report publisher outstanding metrics #6187
Merged
hongalex
merged 10 commits into
googleapis:main
from
schallert:schallert/publisher_outstanding_metrics
Jun 23, 2022
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f979acc
feat(pubsub): report publisher outstanding metrics
schallert fefc6a3
Merge branch 'main' into schallert/publisher_outstanding_metrics
schallert 2808de0
fix topic tag
schallert 2335bb1
Merge branch 'main' into schallert/publisher_outstanding_metrics
hongalex 1732d31
flowcontroller: check all values on recordStat
schallert a198ea5
Merge branch 'main' into schallert/publisher_outstanding_metrics
schallert e7c82d8
Merge branch 'main' into schallert/publisher_outstanding_metrics
schallert 92c9a7b
Merge branch 'main' into schallert/publisher_outstanding_metrics
hongalex 31bae52
remove unknown value
schallert 8c6dd88
Merge branch 'main' into schallert/publisher_outstanding_metrics
hongalex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this fall through to maintain backwards compatibility with the old behavior. However, as written there shouldn't be any cases where a "real" client has an unknown purpose, so I'm happy to make
default
a noop. Or I can remove the unknown value entirely and default toflowControllerPurposeSubscription
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the unknown value since flowcontroller is only used for publisher/subscribers here. Thanks!