New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): support bigquery subscriptions #6119
Merged
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d02cc38
feat(pubsub): support bigquery subscriptions
hongalex 167e6a5
Merge branch 'main' of ssh://github.com/googleapis/google-cloud-go in…
hongalex ed59e12
fix formatting and update comments
hongalex ba76367
run gofmt
hongalex 8c8b73e
simplify fake behavior for bqconfig
hongalex 226aede
Merge branch 'main' of ssh://github.com/googleapis/google-cloud-go in…
hongalex 6cf0954
fix comments
hongalex 70d876d
add comments to exported consts
hongalex 021208a
add SubscriptionState field
hongalex 40f4fce
add comment to exported field
hongalex c040df3
Merge branch 'main' into feat-bigquery-config
hongalex 7df8cc5
add comment to exported type
hongalex e5bbd5a
Merge branch 'feat-bigquery-config' of github.com:hongalex/google-clo…
hongalex 8f79979
fix comment
hongalex 11bb18a
Merge branch 'main' into feat-bigquery-config
hongalex 6a9740e
Merge branch 'main' into feat-bigquery-config
hongalex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added a SubscriptionState field as well as part of this feature. Should we add that here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. I also made the fake return
Active
for both Subscription/BigQueryConfigState by default.