fix(internal/gapicgen): add generation of internal/version.go for new client modules #5726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… client modules This was discovered attempting to generate certificatemanager. New client generation failed with apiv1/version.go: no such file or directory
|
Thanks for helping me with every step of this PR @codyoss !!! |
Merged
BrennaEpp
pushed a commit
to BrennaEpp/google-cloud-go
that referenced
this pull request
Mar 10, 2022
… client modules (googleapis#5726) This was discovered attempting to generate certificatemanager. New client generation failed with apiv1/version.go: no such file or directory - Move genVersionFile before genModule . - Fix path for generation of apivX/version.go file. - Add template and creation of the client's internal/version.go file, conditional on genModule.
Merged
Merged
Merged
This was referenced Apr 14, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discovered attempting to generate certificatemanager.
New client generation failed with
apiv1/version.go: no such file or directorygenVersionFilebeforegenModule.apivX/version.gofile.internal/version.gofile, conditional ongenModule.