Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internal/gapicgen): don't gen version files for longrunning and debugger #5698

Merged
merged 2 commits into from Feb 24, 2022
Merged

fix(internal/gapicgen): don't gen version files for longrunning and debugger #5698

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a722d1
fix(internal/gapicgen): don't gen version files for longrunning and d…
codyoss Feb 24, 2022
a5002ab
Merge branch 'main' into fix-genbot-skip
codyoss Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions internal/gapicgen/generator/gapics.go
View file
Open in desktop
Expand Up @@ -316,6 +316,12 @@ func (g *GapicGenerator) microgen(conf *microgenConfig) error {
}

func (g *GapicGenerator) genVersionFile(conf *microgenConfig) error {
// These directories are not modules on purpose, don't generate a version
// file for them.
if conf.importPath == "cloud.google.com/go/longrunning/autogen" ||
conf.importPath == "cloud.google.com/go/debugger/apiv2" {
return nil
}
relDir := strings.TrimPrefix(conf.importPath, "cloud.google.com/go/")
rootPackage := strings.Split(relDir, "/")[0]
rootModInternal := fmt.Sprintf("cloud.google.com/go/%s/internal", rootPackage)
Expand Down