feat(storage): add Writer.ChunkRetryDeadline #5482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose the ChunkRetryDeadline MediaOption through the manual client layer. This allows users to set a longer deadline for chunk retries in resumable uploads if desired. I also considered this as a RetryOption, but 1. it's only relevant for uploads and 2. it should be configured in conjunction with ChunkSize which is a field on Writer. Updates googleapis/google-api-go-client#685
product-auto-label
bot
added
size: xs
|
Presubmits seem to be failing for everything due to issues with the new Go 1.15 kokoro build; @codyoss PTAL |
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
adityamaru
added a commit
to adityamaru/cockroach
that referenced
this pull request
Apr 22, 2022
This change was motivated by the need to pickup googleapis/google-cloud-go#5482 that makes the `Writer.ChunkRetryDeadline` configurable. Some other notable bumps in this upgrade are: go get: upgraded google.golang.org/api v0.65.0 => v0.75.0 go get: upgraded google.golang.org/grpc v1.43.0 => v1.46.0 go get: upgraded google.golang.org/protobuf v1.27.1 => v1.28.0 Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Apr 23, 2022
80412: go.mod: upgrade cloud.google.com/go/storage to v1.21.0 r=knz a=adityamaru This change was motivated by the need to pickup googleapis/google-cloud-go#5482 that makes the `Writer.ChunkRetryDeadline` configurable. Some other notable bumps in this upgrade are: go get: upgraded google.golang.org/api v0.65.0 => v0.75.0 go get: upgraded google.golang.org/grpc v1.43.0 => v1.46.0 go get: upgraded google.golang.org/protobuf v1.27.1 => v1.28.0 Release note: None Co-authored-by: Aditya Maru <adityamaru@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the ChunkRetryDeadline MediaOption through the manual
client layer. This allows users to set a longer deadline for
chunk retries in resumable uploads if desired.
I also considered this as a RetryOption, but 1. it's only
relevant for uploads and 2. it should be configured in
conjunction with ChunkSize which is a field on Writer.
Updates googleapis/google-api-go-client#685