Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(logging): handle TestListLogEntriesRequest flakiness #5460

Merged
merged 6 commits into from Feb 23, 2022
Merged

chore(logging): handle TestListLogEntriesRequest flakiness #5460

merged 6 commits into from Feb 23, 2022

Commits on Feb 14, 2022

  1. chore(fix): handle TestListLogEntriesRequest flakiness 

    remove timestamp comparison which fails due to (milli-)seconds mismatch when
executing time.Now() to get filter time delayed after time.Now() in the test.
separately test default (-24h) look back period
    @minherz
    minherz committed Feb 14, 2022
    Copy the full SHA
    2f5524b View commit details
    Browse the repository at this point in the history

  2. chore: refactor tests 

    align error message with expected format
refactor testing params for TestListLogEntriesRequest
    @minherz
    minherz committed Feb 14, 2022
    Copy the full SHA
    2f54167 View commit details
    Browse the repository at this point in the history

  3. chore: format error messages after the pattern

    @minherz
    minherz committed Feb 14, 2022
    Copy the full SHA
    e471e1b View commit details
    Browse the repository at this point in the history

  4. chore: small error text adjustment

    @minherz
    minherz committed Feb 14, 2022
    Copy the full SHA
    6b3e85e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into minherz/fix-5441

    @codyoss
    codyoss committed Feb 14, 2022
    Copy the full SHA
    9ddc32b View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Merge branch 'main' into minherz/fix-5441

    @minherz
    minherz committed Feb 23, 2022
    Copy the full SHA
    f37dea7 View commit details
    Browse the repository at this point in the history