Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bigquery/storage/managedwriter): improve readability #5239

Merged
merged 3 commits into from Dec 21, 2021

Conversation

shollyman
Copy link
Contributor

This PR introduces no functional changes. It simply colocates the
two types of variadic options into the same file to aid readability.

Towards: #4366

This PR introduces no functional changes.  It simply colocates the
two types of variadic options into the same file to aid readability.

Towards: googleapis#4366
@shollyman shollyman requested a review from a team December 21, 2021 20:51
@shollyman shollyman requested a review from a team as a code owner December 21, 2021 20:51
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Dec 21, 2021
@shollyman shollyman enabled auto-merge (squash) December 21, 2021 20:51
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman merged commit c6c8522 into googleapis:main Dec 21, 2021
@shollyman shollyman deleted the refactor branch December 22, 2021 00:24
BrennaEpp pushed a commit to BrennaEpp/google-cloud-go that referenced this pull request Dec 23, 2021
…apis#5239)

This PR introduces no functional changes.  It simply colocates the
two types of variadic options into the same file to aid readability.

Towards: googleapis#4366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants