Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(bigquery/storage/managedwriter): augment docs #5208

Merged
merged 5 commits into from Dec 13, 2021

Conversation

shollyman
Copy link
Contributor

Towards: #4366

@shollyman shollyman requested a review from a team December 9, 2021 00:29
@shollyman shollyman requested a review from a team as a code owner December 9, 2021 00:29
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Dec 9, 2021
@shollyman shollyman requested a review from tswast December 9, 2021 00:31
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice docs!

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you covered the main topics. Just a minor nit

bigquery/storage/managedwriter/doc.go Outdated Show resolved Hide resolved
@shollyman shollyman enabled auto-merge (squash) December 13, 2021 17:11
@shollyman shollyman merged commit 0dca864 into googleapis:main Dec 13, 2021
@shollyman shollyman deleted the docs-managedwriter branch December 13, 2021 17:36
BrennaEpp pushed a commit to BrennaEpp/google-cloud-go that referenced this pull request Dec 23, 2021
* docs(bigquery/storage/managedwriter): augment docs

* make wordings more gooder

* Update bigquery/storage/managedwriter/doc.go

Co-authored-by: Tim Swast <swast@google.com>

Co-authored-by: Tim Swast <swast@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants