feat: expose the query source of a rowiterator via SourceJob() #4748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RowIterator can currently come from calling Read() on a Table, Read() on a Job, and Read() directly from a Query. The third invocation is used for fast path queries and doesn't return a query identifier suitable for gathering statistics. This PR exposes a SourceJob() method on RowIterator to address this issue. Users still get the benefits of optimized query execution, but can get the reference to a Job for looking up additional statistics should they need it.
google-cla
bot
added
the
cla: yes
shollyman
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RowIterator can currently come from calling Read() on a Table,
Read() on a Job, and Read() directly from a Query. The third invocation
is used for fast path queries and doesn't return a query identifier
suitable for gathering statistics.
This PR exposes a SourceJob() method on RowIterator to address this
issue. Users still get the benefits of optimized query execution, but
can get the reference to a Job for looking up additional statistics
should they need it.
Fixes: #4745