Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bigquery/storage/managedwriter): change AppendRows behavior #4729

Merged
merged 2 commits into from Sep 8, 2021
Merged

refactor(bigquery/storage/managedwriter): change AppendRows behavior #4729

merged 2 commits into from Sep 8, 2021

Commits on Sep 7, 2021

  1. BREAKING CHANGE(bigquery/storage/managedwriter): change AppendRows 

    behavior

Previously, AppendRows() on a managed stream would return one
AppendResult per data row.  This change instead switches the
behavior to return a single AppendResult for tracking the behavior
of the set of rows.

The original per-row contract was done in expectation that we'd
consider making batching decisions are a very granular level. However,
at this point it seems reasonable to consider only batching multiple
appends, not dividing individual batchs more granularly.
    @shollyman
    shollyman committed Sep 7, 2021
    Copy the full SHA
    01af63d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into single-appendresult

    @shollyman
    shollyman committed Sep 7, 2021
    Copy the full SHA
    aa33765 View commit details
    Browse the repository at this point in the history