New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pubsub): add topic message retention duration #4520
Merged
Merged
Changes from 10 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
281023d
feat(pubsub): add message retention duration feature
hongalex 49312e1
Merge branch 'master' of ssh://github.com/googleapis/google-cloud-go …
hongalex b7ab72e
merge master
hongalex 4d7b13d
feat(pubsub): add topic message retention duration
hongalex 0ab977e
Merge branch 'master' into pubsub_dev
hongalex 6f0be96
Merge branch 'master' into pubsub_dev
hongalex 67f7c55
comment fixes
hongalex ec68835
Merge branch 'pubsub_dev' of ssh://github.com/googleapis/google-cloud…
hongalex 7806d4a
resolve go.mod merge
hongalex 54c1591
merge with master and use genproto head
hongalex a574ca2
switch to optional.Duration
hongalex f0635a2
remove staging endpoint
hongalex cbd6456
address review comments
hongalex fe71f8b
remove unused instance of message retention duration in publishsettings
hongalex 7808596
revert sentinel value check
hongalex 0728715
clarify doc comments
hongalex 89ae270
Merge branch 'master' into pubsub_dev
hongalex 92be15f
fix retention duration comments
hongalex 8e10b3e
Merge branch 'pubsub_dev' of ssh://github.com/googleapis/google-cloud…
hongalex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear: this is an "output only" field? I know this isn't a proto field, but just want to clarify with https://google.aip.dev/203#output-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is an output only field, correspondig to https://github.com/googleapis/googleapis/blob/ba30d8097582039ac4cc4e21b4e4baa426423075/google/pubsub/v1/pubsub.proto#L761.
Should I explicitly add this to the comments here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine the way it is, but maybe it would be clearer to say
This is an output only field, meaning it will only appear in responses from the backend and will be ignored if sent in a request.
You could include the link too if you feel it would be helpful.No change is really needed, just wanted to clarify for myself.