Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing(bigquery/storage/managedwriter): extend table validation functionality #4517

Merged
merged 5 commits into from Jul 30, 2021

Conversation

shollyman
Copy link
Contributor

Soon we'll start tackling null values and complex schemas, so this PR augments the existing table validator with one that can be passed multiple validation constraints for evaluation (how many rows, how many nulls, cardinality, etc). It updates the existing integration tests to use the new validator, and tightens validation to ensure that tests are propagating the appended values as expected.

Towards: #4366

This adds a small query builder for evaluating statistical properties of
the table (total rows, column cardinality, null frequency, etc), and
updates integration tests to use the new builder
@shollyman shollyman requested a review from a team as a code owner July 29, 2021 19:15
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jul 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2021
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shollyman shollyman added the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 14e9829 into googleapis:master Jul 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants