Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsublite): set a default grpc connection pool size of 8 #4462

Merged
merged 1 commit into from Jul 20, 2021
Merged

fix(pubsublite): set a default grpc connection pool size of 8 #4462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 9 additions & 3 deletions pubsublite/internal/wire/rpc.go
View file
Open in desktop
Expand Up @@ -192,24 +192,30 @@ func defaultClientOptions(region string) []option.ClientOption {
}
}

func streamClientOptions(region string) []option.ClientOption {
// To ensure most users don't hit the limit of 100 streams per connection, if
// they have a high number of topic partitions.
return append(defaultClientOptions(region), option.WithGRPCConnectionPool(8))
}

// NewAdminClient creates a new gapic AdminClient for a region.
func NewAdminClient(ctx context.Context, region string, opts ...option.ClientOption) (*vkit.AdminClient, error) {
options := append(defaultClientOptions(region), opts...)
return vkit.NewAdminClient(ctx, options...)
}

func newPublisherClient(ctx context.Context, region string, opts ...option.ClientOption) (*vkit.PublisherClient, error) {
options := append(defaultClientOptions(region), opts...)
options := append(streamClientOptions(region), opts...)
return vkit.NewPublisherClient(ctx, options...)
}

func newSubscriberClient(ctx context.Context, region string, opts ...option.ClientOption) (*vkit.SubscriberClient, error) {
options := append(defaultClientOptions(region), opts...)
options := append(streamClientOptions(region), opts...)
return vkit.NewSubscriberClient(ctx, options...)
}

func newCursorClient(ctx context.Context, region string, opts ...option.ClientOption) (*vkit.CursorClient, error) {
options := append(defaultClientOptions(region), opts...)
options := append(streamClientOptions(region), opts...)
return vkit.NewCursorClient(ctx, options...)
}

Expand Down