Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(storage): unflake PublicAccessPrevention test #4352

Merged
merged 2 commits into from Jul 1, 2021
Merged

test(storage): unflake PublicAccessPrevention test #4352

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d992e
test(storage): unflake PublicAccessPrevention test
tritone Jun 30, 2021
dadc48c
Merge branch 'master' into pap-fix
tritone Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 8 additions & 3 deletions storage/integration_test.go
View file
Open in desktop
Expand Up @@ -627,9 +627,14 @@ func TestIntegration_PublicAccessPrevention(t *testing.T) {
t.Error("updating PublicAccessPrevention changed UBLA setting")
}

// Now, making object public or making bucket public should succeed.
a = o.ACL()
if err := a.Set(ctx, AllUsers, RoleReader); err != nil {
// Now, making object public or making bucket public should succeed. Run with
// retry because ACL settings may take time to propagate.
if err := retry(ctx,
func() error {
a = o.ACL()
return a.Set(ctx, AllUsers, RoleReader)
},
nil); err != nil {
t.Errorf("ACL.Set: making object public failed: %v", err)
}
policy, err = bkt.IAM().V3().Policy(ctx)
Expand Down