Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release spanner 1.22.0 #4339

Merged
merged 2 commits into from Jun 30, 2021
Merged

chore: release spanner 1.22.0 #4339

merged 2 commits into from Jun 30, 2021

Conversation

yoshi-code-bot
Copy link
Contributor

@yoshi-code-bot yoshi-code-bot commented Jun 29, 2021

馃 I have created a release *beep* *boop*

1.22.0 (2021-06-30)

Features

  • spanner: support request and transaction tags (#4336) (f08c73a)
  • spanner: enable request options for batch read (#4337) (b9081c3)

This PR was generated with Release Please. See documentation.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 29, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2021
@hengfengli
Copy link
Contributor

@olavloite Interesting. Why #4336 does not appear in this release? I'd like to release the tagging work together.

@olavloite
Copy link
Contributor

olavloite commented Jun 30, 2021

@olavloite Interesting. Why #4336 does not appear in this release? I'd like to release the tagging work together.

Hmm... That's strange. The commit is in the release, but it does not show up in the list of changes. I think that is because the commit got a non-conforming commit message: https://github.com/googleapis/google-cloud-go/pull/4336/commits (It starts with Revert ("revert...)

I guess the best solution in this case is to manually edit the release notes.

@hengfengli
Copy link
Contributor

@codyoss I can't push my change to this PR. Is there any way that I can update the release note (CHANGES.md) by adding the missing commit?

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 30, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2021
@hengfengli
Copy link
Contributor

It's interesting that I did it successfully via Github UI by directly editing the file. But when I did update the file locally, I failed to push my change. What I have done is:

gh pr checkout 4339
vim spanner/CHANGES.md
git add spanner/CHANGES.md
git commit
git push origin HEAD:refs/pull/4339/head

I got the error:

Enumerating objects: 11, done.
Counting objects: 100% (11/11), done.
Delta compression using up to 12 threads
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 979 bytes | 326.00 KiB/s, done.
Total 8 (delta 6), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (6/6), completed with 3 local objects.
To github.com:googleapis/google-cloud-go.git
 ! [remote rejected]     HEAD -> refs/pull/4339/head (deny updating a hidden ref)
error: failed to push some refs to 'github.com:googleapis/google-cloud-go.git'

Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codyoss
Copy link
Member

codyoss commented Jun 30, 2021

Looks like it is all good now, lmk if my assistance is still needed.

@hengfengli hengfengli merged commit 6e1be41 into googleapis:master Jun 30, 2021
@github-actions
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorelease: published cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants