Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(internal): update microgen to v0.21.2 #4315

Merged
merged 4 commits into from Jun 29, 2021
Merged

chore(internal): update microgen to v0.21.2 #4315

merged 4 commits into from Jun 29, 2021

Conversation

noahdietz
Copy link
Contributor

Changes include:

  • add initial rest client generation (behind transport=rest flag)
  • add EnableJwtWithScope default client options cc @shinfan
  • dependency updates

@noahdietz noahdietz requested a review from a team as a code owner June 24, 2021 19:55
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 24, 2021
@noahdietz noahdietz mentioned this pull request Jun 24, 2021
Merged
@noahdietz noahdietz changed the title chore(internal): update microgen to v0.21.0 chore(internal): update microgen to v0.21.2 Jun 28, 2021
codyoss
codyoss approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets hold off merging until regen runs today

@codyoss codyoss added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 29, 2021
@codyoss
Copy link
Member

codyoss commented Jun 29, 2021

The PR is out, this is now safe to merge.

@noahdietz noahdietz added the automerge Merge the pull request once unit tests and other checks pass. label Jun 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit e4a5791 into googleapis:master Jun 29, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 29, 2021
@noahdietz noahdietz deleted the update-microgen branch June 29, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noahdietz @codyoss